#18529: Topological manifolds: basics
-------------------------------------+-------------------------------------
Reporter: egourgoulhon | Owner: egourgoulhon
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.0
Component: geometry | Resolution:
Keywords: topological | Merged in:
manifolds | Reviewers: Travis Scrimshaw
Authors: Eric Gourgoulhon, | Work issues:
Travis Scrimshaw | Commit:
Report Upstream: N/A | 984c3c26bf827f44eee26fc6afd321e11dca8f2e
Branch: | Stopgaps:
public/manifolds/top_manif_basics |
Dependencies: #18175 |
-------------------------------------+-------------------------------------
Comment (by egourgoulhon):
Replying to [comment:117 tscrim]:
> I also think this discussion was good. I'm just slightly frustrated at
myself for not being able to come up with a clear better alternative to
get rid of the code smell.
>
I think there is still the opportunity to implement another hierarchy
latter, if we feel that specificities for subsets are required. Also, if
we do this latter, when more tickets of #18528 are merged, this would
alleviate the propagation of the changes to other tickets and one would
notice at once possible side effects.
> Anyways, now it is back to going over the documentation and
technicalities of the code. I hope to finish this review in a couple of
days.
Thanks.
> I'm also thinking that the followup tickets will probably be a lot
easier/faster to review too.
I've propagated the latest changes in this ticket to all tickets of
#18528. Everything is OK. In particular, the new singleton classes for
manifold structures have allowed to simplify the code, avoiding to
redefine the methods `chart` and `scalar_field_algebra` in the class
`DifferentiableManifold`.
--
Ticket URL: <http://trac.sagemath.org/ticket/18529#comment:118>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
