#18529: Topological manifolds: basics
-------------------------------------+-------------------------------------
Reporter: egourgoulhon | Owner: egourgoulhon
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.1
Component: geometry | Resolution:
Keywords: topological | Merged in:
manifolds | Reviewers: Travis Scrimshaw,
Authors: Eric Gourgoulhon, | Eric Gourgoulhon
Travis Scrimshaw | Work issues:
Report Upstream: N/A | Commit:
Branch: | 00d265cf2855121dba914868264da6ea3a9c42af
public/manifolds/top_manif_basics | Stopgaps:
Dependencies: #18175 |
-------------------------------------+-------------------------------------
Comment (by egourgoulhon):
Replying to [comment:120 tscrim]:
> Okay, I've made my last pass through everything.
Thanks a lot for all your changes.
> I have two comments left:
>
> - In `Chart.set_inverse`, there is a keyword `check` that I changed to
`verbose` because there was no check being done.
Yes, `verbose` seems more appropriate.
> Irregardless, I don't quite like that the default is to print things to
the terminal. Is there a specific reason for this?
No.
>I feel like the default should be `False`.
I've set it to `False` in the above commit.
> - In `ManifoldPoint`, the methods `set_coord` should be the full
`set_coordinates` (and similar methods). The short version can be an
alias. (Same discussion as for `disp` vs `display`.).
>
I've performed the change in the above commit, adding aliases for short
versions of `coordinates`, `add_coordinates` and `set_coordinates`. I've
also corrected one or two typos.
--
Ticket URL: <http://trac.sagemath.org/ticket/18529#comment:123>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
