#19890: Improve standardization
-------------------------------------+-------------------------------------
       Reporter:  elixyre            |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.0
      Component:  combinatorics      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Jean-Baptiste      |    Reviewers:  Travis Scrimshaw
  Priez                              |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  b248fb55c423ffc380700234be22fa7a37ace3c2
  u/elixyre/standardization          |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by elixyre):

 Replying to [comment:2 tscrim]:
 > That is quite the improvement. Here are some comments and suggestions:
 >
 > - Why do you import `imap`? You don't seem to use it.

 Sorry, it is a mistake... I was to fast and I forgot to remove that.

 > - Are you going to delete the old algorithm or keep it and add an
 `algorithm` option? I would at least keep the old (naive) algorithm around
 in a doctest for testing.

 I deleted the old below and I had it in doctest!

--
Ticket URL: <http://trac.sagemath.org/ticket/19890#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to