#19306: common generators for asymptotic expansions
-------------------------------------+-------------------------------------
Reporter: dkrenn | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.0
Component: asymptotic | Resolution:
expansions | Merged in:
Keywords: | Reviewers: Clemens Heuberger
Authors: Daniel Krenn | Work issues:
Report Upstream: N/A | Commit:
Branch: | eac4977efef3ebebc16dce1cacf9c019dd4c236a
u/dkrenn/asy/generators | Stopgaps:
Dependencies: #19259, #19305 |
-------------------------------------+-------------------------------------
Changes (by dkrenn):
* status: needs_info => needs_review
* commit: a4c3f9d99c756c11a4c4be97e435eee1ff4511d9 =>
eac4977efef3ebebc16dce1cacf9c019dd4c236a
Comment:
Replying to [comment:15 cheuberg]:
> I reviewed this ticket (without looking at its dependency #19259). I
added a commits, they need cross-review.
Done.
> Two questions concerning `misc.split_str_by_op`:
> - Why `+= -1` instead of `-= 1`?
Changed.
> - What is the purpose of the `for...else` construct: there is no `break`
anyway.
Changed. (`else` came from an old code)
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=eac4977efef3ebebc16dce1cacf9c019dd4c236a
eac4977]||{{{Trac #19306: minor changes (cross-review and incorporate
reviewer comments)}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/19306#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
