#19843: Improve location change error message
-------------------------------------+-------------------------------------
       Reporter:  vbraun             |        Owner:
           Type:  defect             |       Status:  needs_work
       Priority:  blocker            |    Milestone:  sage-7.0
      Component:  build              |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Volker Braun       |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/vbraun/improve_location_change_error_message|  
b46f637d271f256c8b085adc599d921e7ae11dcf
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jdemeyer):

 * status:  needs_review => needs_work


Comment:

 This is a bit sloppy. Why keep all the functions
 `update_pkgconfig_files()`, `make_scripts_relative()`, `sage_relocate()`
 if they aren't used anymore? You might argue that they will still be
 called when running Sage ''the first time''. However, they won't be called
 anymore when upgrading packages. So there is really no point in running
 them just once.

 Either you run them every time a package is installed (like it used to be)
 or you never run them.

 Second, the `check_processor_flags()` function becomes pointless since
 it's only run on the machine which created the binary, not on the machine
 running the binary. But maybe we should consider `check_processor_flags()`
 obsolete and just remove it.

--
Ticket URL: <http://trac.sagemath.org/ticket/19843#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to