#19659: Poset: inverse function of ordinal_sum()
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.0
Component: combinatorics | Resolution:
Keywords: poset | Merged in:
Authors: Jori Mäntysalo | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jmantysalo/develop | 01f9e1c6bb502e6044181c856bcb8984718fd237
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by jmantysalo):
Replying to [comment:30 ncohen]:
> Actually, could you answer this very central question: why do you
believe we should implement every function twice, once in Poset and once
in !HasseDiagram? Is it only because of the cost of the Poset constructor?
Not only that. Earlier in this ticket you said
>> Perhaps something like "whatever was once useful to one must be a
public method". In the case of very very specific functions, sometimes
hard to document properly, I do not believe that it is a good choice.
I think that "visible" poset functions, i.e. those not starting with `_`,
should give meaningful set of operations to do with posets. It does not
always directly correspond with good structure for internal functions. So
should I add a `_`-function to `posets.py` or add a strange option for
`ordinal_decomposition` to be used just for series-parallel decomposition?
Both options sounds strange, as the already have "internal" class.
> I only click on `positive_review` when I am personally satsfied with the
code.
I know. It's hard to get a `positive_review` from you, but easy to get
performance tips etc. in the process. `:=)`
--
Ticket URL: <http://trac.sagemath.org/ticket/19659#comment:31>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
