#19659: Poset: inverse function of ordinal_sum()
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.0
Component: combinatorics | Resolution:
Keywords: poset | Merged in:
Authors: Jori Mäntysalo | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jmantysalo/develop | 01f9e1c6bb502e6044181c856bcb8984718fd237
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by ncohen):
> I can change that, if you want.
I was just suggesting it. If you don't like it, then it's fine.
> So actually I want an answer to two questions: 1) Is Sage better with or
without this patch? 2) Is there some trivial things that would make this
patch better? Those two are my criteria for giving a positive review.
Then it is likely that you would give your patch a positive review.
> `break-else` is really a python special feature. Quite nice sometimes
with this kind on mathematical code.
And it was not a problem at all with how it was used before you added the
'degree check'. Nesting two looks a bit unpleasant to me, which is why I
suggested this 'all( ... )' thing but I can understand that it only
matters to me.
What you need however, is a Poset class with a less wasteful constructor.
You seem to use `HasseDiagram` to this end.
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/19659#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
