#19891: improve coding style and documentation in projective schemes
-------------------------------------+-------------------------------------
Reporter: bhutz | Owner: bhutz
Type: enhancement | Status: new
Priority: trivial | Milestone: sage-7.0
Component: algebraic | Resolution:
geometry | Merged in:
Keywords: | Reviewers: Frédéric Chapoton
Authors: | Work issues:
Report Upstream: N/A | Commit:
Branch: | 7aac718894d13b8f52373ec0f38d080dca3ed162
u/bhutz/ticket/19891 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by chapoton):
* commit: => 7aac718894d13b8f52373ec0f38d080dca3ed162
* reviewer: => Frédéric Chapoton
Comment:
Please put this ticket in "needs_review". I have assumed that you forgot
to do so.
Here are some points that I have seen at first reading.
{{{
+ See [Hutz-gr]
}}}
is wrong. The correct refererence syntax is {{{[Hutz-gr]_}}} with an
underscore at the end. This happen at many places, for example also for
`See [FMV]` and `[Silverman_ADS]` and `[Bruin-Molnar] and [Molnar]`.
{{{
`PGL(2,QQ)`
}}}
could be
{{{
`PGL(2,\QQ)`
}}}
This looks strange:
{{{
- lift,lifted = blift(LG,Li,p,S=S)
+ lift,lifted = blift(LG,Li,p,S = S)
}}}
{{{Abelian variety}}} should keep its capital A
{{{
+ returns ``True`` if this map is a morphism.
}}}
should be
{{{
+ Return ``True`` if this map is a morphism.
}}}
{{{greens function}}} should be {{{Green's function}}}
{{{+ THis map must}}}
should be
{{{+ This map must}}}
typo {{{the subsgroup}}} at least twice
typo {{{post-critially}}}
typo {{{the the LLL}}}
duplicate reference {{{[Hutz_gr]}}} and {{{[Hutz-gr]}}} ?
typo {{{this projective spaces}}}
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=0db500bd8c542990f74defe63f2eaac1afa23697
0db500b]||{{{19891: fixes for endPN_minimal_model.py}}}||
||[http://git.sagemath.org/sage.git/commit/?id=9fcac6792f0c1fe83f43b688f86279f99c191ae5
9fcac67]||{{{19891: fixes for projective_homset.py}}}||
||[http://git.sagemath.org/sage.git/commit/?id=293dd6cb6193237065010365475eeabc18363380
293dd6c]||{{{19891: fixes for endPN_automorphism_group.py}}}||
||[http://git.sagemath.org/sage.git/commit/?id=069751e699adf48521a2697f636ef1b41676a877
069751e]||{{{19891: fixes for projective_morphism.py}}}||
||[http://git.sagemath.org/sage.git/commit/?id=8c073bc82a5dc2e7184b83e4939eea4a3cb0e953
8c073bc]||{{{19891: fixes for projective_morphism_help.py and update
references}}}||
||[http://git.sagemath.org/sage.git/commit/?id=d90476d0af5beada24e828b3d3f01a63ec40d575
d90476d]||{{{19891 fixes for projective_point.py}}}||
||[http://git.sagemath.org/sage.git/commit/?id=935c0ec0e7b994d4d8e908654b362503dbbe4bfb
935c0ec]||{{{19891: fixes for projective_rational_point.py}}}||
||[http://git.sagemath.org/sage.git/commit/?id=ce4dac1592ee7e09835c3fa598f4f36f1020ec7d
ce4dac1]||{{{19891: fixes for projective_space.py}}}||
||[http://git.sagemath.org/sage.git/commit/?id=7aac718894d13b8f52373ec0f38d080dca3ed162
7aac718]||{{{19891: doc formatting clean-up}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/19891#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
