#19623: Syndrome decoder is not a syndrome decoder
-------------------------------------+-------------------------------------
Reporter: dlucas | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-7.0
Component: coding theory | Resolution:
Keywords: | Merged in:
Authors: David Lucas | Reviewers: Julien Lavauzelle
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/dlucas/generic_decoders | b2b9e8270a95e7478760532827be04cecb906510
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by dlucas):
Hello,
I changed the following in my code:
- I renamed `number_errors` as `maximum_error_weight`. I changed
accordingly the description given by representation methods `_latex_` and
`_repr_`. I also renamed its getter (from `number_errors` to
`maximum_error_weight`), and changed its docstring.
- `covering_radius` now returns `min(maximum_error_weight, half-min-
dist`). I changed its docstring and added a note to explain it performs a
minimum distance computation, which can be long...
- I rewrote `_list_all_error_values`, which now takes an input parameter
`weight` and builds only the exhaustive list of error values of weight
`weight`. It now uses `cartesian_product` instead of `Permutation`.
- I rewrote `_build_lookup_table`, which now uses a `for` loop. I removed
the useless lexicographic order check. It still terminates early if no new
pattern is added during a loop.
- The input of `decode_to_code` is now copied ''before'' modification.
- Finally, I fixed a few broken doctests, and removed the keyword
`complete` in `decoder_type` as computing the covering radius can only be
done by a call to a method forcing the use of optional library Guava.
Ticket #19913 proposes a new `covering_radius` method which has a Python
alternative to Guava. Once this ticket (or #19913) gets reviewed, I'll do
the appropriate updates wrt. covering radius in the remaining one.
Sorry about this poorly written code, it should be better now.
David
--
Ticket URL: <http://trac.sagemath.org/ticket/19623#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
