#19127: Some clean up in docbuilding
-------------------------------------+-------------------------------------
       Reporter:  jdemeyer           |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.9
      Component:  build              |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Jeroen Demeyer     |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/jdemeyer/ticket/19127            |  7c98158ec8ee9e3ec98427ef7d0a0dcf208469d9
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by mmezzarobba):

 LGTM. Two minor comments though:
 * I wonder why you renamed the logger to `doc.builder` (the obvious reason
 to change the name would be to follow the more-or-less standard convention
 of “namespacing” it using the corresponding Python module name, but that's
 not what you do).
 * The developer guide contains a mention of
 `SAGE_ROOT/src/doc/builder/__init__.py` that probably should be updated or
 removed.

--
Ticket URL: <http://trac.sagemath.org/ticket/19127#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to