#19957: Asymptotic ring: list plot comparing values
-------------------------------------+-------------------------------------
Reporter: cheuberg | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.1
Component: asymptotic | Resolution:
expansions | Merged in:
Keywords: | Reviewers: Clemens Heuberger
Authors: Benjamin Hackl, | Work issues:
Clemens Heuberger | Commit:
Report Upstream: N/A | 51668a9d5c0b8af1c11f9d5b1703e326e7b4d317
Branch: u/behackl/asy | Stopgaps:
/compare-with-values |
Dependencies: #19931 |
-------------------------------------+-------------------------------------
Changes (by behackl):
* status: needs_work => needs_review
* commit: 5b20379b8dafbf0467eb040d55bc0d857f2a1ea3 =>
51668a9d5c0b8af1c11f9d5b1703e326e7b4d317
* branch: u/cheuberg/asy/compare-with-values => u/behackl/asy/compare-
with-values
Comment:
Thanks for looking over my adaptions!
Replying to [comment:10 cheuberg]:
> 1. `compare_with_value` should have a parameter `ring=RIF` and results
should be converted into ring
Done.
> 2. Examples section should still contain an example with a function
Done.
> 3. `see also` block from `compare_with_value` to `plot_comparison`
Done.
> 4. why `*kwargs` in the call of `list_plot` instead of `**kwargs`?
Typo. Fixed.
> 5. Example with non-trivial arguments, i.e. setting a color.
I've added a more sophisticated doctest.
> 6. `plot_comparison` will then need conversion from RIF to RR; this
could also check whether there is still precision left (relative error of
1% seems to be tolerable for a plot) and raise an error otherwise.
Done. The check currently is for a relative diameter of less than `0.025`,
which seems like a somewhat practical choice (the example with the
harmonic numbers then works up to `n \approx 500`).
> 7. `plot_comparison` should also accept a `ring`; it should be
documented and treated to be a `RealIntervalField`.
Done.
Back to `needs_review`.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=204102747facf31e42e48f79191ebac77b7f0acb
2041027]||{{{Trac #19957: reviewer commit}}}||
||[http://git.sagemath.org/sage.git/commit/?id=0990eedfee8f6d1df40249c3cadf4353a9bd6038
0990eed]||{{{add ring-parameter for compare_with_value}}}||
||[http://git.sagemath.org/sage.git/commit/?id=6d1de2306f6ad886a52a80ce7b4fa0e047ae3b0a
6d1de23]||{{{adapt doctests}}}||
||[http://git.sagemath.org/sage.git/commit/?id=7a6c9bb344f3ca51d1ba4b00622a97978af72c59
7a6c9bb]||{{{add doctest with function}}}||
||[http://git.sagemath.org/sage.git/commit/?id=7023a0ea2c422c9ce794ced64b7d35dda8942a97
7023a0e]||{{{add seealso-block}}}||
||[http://git.sagemath.org/sage.git/commit/?id=f0f349dc3cfddcd858bf95a9cbeaef331046d8e6
f0f349d]||{{{add doctest with plot-options}}}||
||[http://git.sagemath.org/sage.git/commit/?id=154299f78fc9d49896e5134cf341f6d9de774e05
154299f]||{{{let plot_comparison deal with RIFs}}}||
||[http://git.sagemath.org/sage.git/commit/?id=79bbc618c4a664673d87d4c2135bad4b7e3b0c49
79bbc61]||{{{improve code in loop}}}||
||[http://git.sagemath.org/sage.git/commit/?id=51668a9d5c0b8af1c11f9d5b1703e326e7b4d317
51668a9]||{{{add doctest for numerical noise check}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/19957#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
