#19957: Asymptotic ring: list plot comparing values
-------------------------------------+-------------------------------------
       Reporter:  cheuberg           |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.1
      Component:  asymptotic         |   Resolution:
  expansions                         |    Merged in:
       Keywords:                     |    Reviewers:  Clemens Heuberger,
        Authors:  Benjamin Hackl,    |  Daniel Krenn
  Clemens Heuberger                  |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  u/dkrenn/asy       |  0632fd3d610aa1c53ecd9b562c67502cb4ac4986
  /compare-with-values               |     Stopgaps:
   Dependencies:  #19931             |
-------------------------------------+-------------------------------------
Changes (by dkrenn):

 * commit:  51668a9d5c0b8af1c11f9d5b1703e326e7b4d317 =>
     0632fd3d610aa1c53ecd9b562c67502cb4ac4986
 * reviewer:  Clemens Heuberger => Clemens Heuberger, Daniel Krenn


Comment:

 I've added a couple of small commits during review. Please check.

 Two comments:

 - I find the naming of a variable `e` confusing...maybe using `expansion`
 would be better?

 - In the plot the hard-coded `0.025` should be adjustable by a parameter.
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=311141f470e02517b8a77a42a42e8c39366863ae
 311141f]||{{{Trac 19957 review: minor code rewrite}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=7337e61b5fa3ee422d8a4388780e9a0c1c83fe3b
 7337e61]||{{{Trac 19957 review: restructure part of the code and remove
 inner list to make it better readable}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=0632fd3d610aa1c53ecd9b562c67502cb4ac4986
 0632fd3]||{{{Trac 19957 review: minor changes in doc}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/19957#comment:14>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to