#19583: random triangulation as simplicial complex
-------------------------------------+-------------------------------------
       Reporter:  chapoton           |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.1
      Component:  algebraic          |   Resolution:
  topology                           |    Merged in:
       Keywords:  random simplicial  |    Reviewers:
  complex                            |  Work issues:
        Authors:  Frédéric Chapoton  |       Commit:
Report Upstream:  N/A                |  5962b8cc85212dccbfeb0fa9fcd68e1ec87bb696
         Branch:  u/chapoton/19583   |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by ncohen):

 Hello,

 The branch looks good. I only wonder about that: why keep it?

 {{{
 +    # graph.relabel()   # does not act on the embedding !
 }}}

 If you expect `.relabel()` to apply to the embedding, then the right
 reaction is to write a bugfix, isn't it?

 Could you also add a doctest like that?

 {{{
 sage: for i in range(10):
 ....:    g = graphs.RandomTriangulation(10)
 ....:    assert g.is_planar(on_embedding=g.get_embedding())
 }}}

 I let it run for a long time, but that's probably safer to have it in the
 tests.

 Thanks,

 Nathann

--
Ticket URL: <http://trac.sagemath.org/ticket/19583#comment:39>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to