#19889: improve coding style and documentation style in affine schemes
-------------------------------------+-------------------------------------
Reporter: bhutz | Owner: rlmiller
Type: enhancement | Status: needs_work
Priority: trivial | Milestone: sage-7.0
Component: algebraic | Resolution:
geometry | Merged in:
Keywords: | Reviewers: Ben Hutz
Authors: Rebecca Miller | Work issues:
Report Upstream: N/A | Commit:
Branch: | eda3eef58a5b921d0e5a775551c6f20c490430ce
u/rlmiller/ticket/19889 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by bhutz):
* status: needs_review => needs_work
* reviewer: => Ben Hutz
Comment:
Most of these are minor. But there are couple places the code can be
improved. All changes referenced by line number.
affine_space.py
- 44 - ``x``
- 60 = ``n``, ``R``
- 223,224 - ``F``
- 397+ -> polys should be ``v``
- 419 - ``v``
- 490 - ``R``
- 525 - line too long
- 530 - line too long
- 646 - ``X``
- 744 - self
- 747 - line too long
- 756 - self
- 814 - If sentence in new paragraph
affine_point.py
- 102 - empty line between
- 112 - ',space'
- 139 - line too long
- 146 - empty line between
- 177 - '=' (is this line even needed?)
- 241 - number field, number field order
- 293 - self
- 355-357 - can be OUTPUT: integer.
- 390 - line too long
- 405 - y*z (no space)
- 422 - ,space
- 428,429 - are these really needed
affine_morphism.py
- 174 - line too long
- 176 - line too long
- 192 - Better would be "if the two affine maps defined the same map),
line too long
- 229 - same comment as 192
- 330 - line too long
- 343 - line too long
- 347 - line too long
- 358 - ,space
- 383 - line too long
- 439 - line too long
- 501 - line too long
- 583 - ``n``
- 658 - ``n``
- 662 - map's
- 663 - empty line between
- 667 - map's
- 703 - no blank line
- 709 - empty line between
- 743 - fix spaces around =
- 753 - ,space
- 755 - line too long
- 770 - space+space
- 780 - space+space
- 784 - this to do I think is done (#15376), so you can probably remove
the special case code.
- 813,814 - single `
- 824 - space-space
- 865 - empty line between
- 996 - line too long
- 1001 - map's
- 1027 - ``x``
- 1066 - line too long, need single line description
- 1071 - OUTPUT: a digraph.
--
Ticket URL: <http://trac.sagemath.org/ticket/19889#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
