#19889: improve coding style and documentation style in affine schemes
-------------------------------------+-------------------------------------
       Reporter:  bhutz              |        Owner:  rlmiller
           Type:  enhancement        |       Status:  needs_work
       Priority:  trivial            |    Milestone:  sage-7.0
      Component:  algebraic          |   Resolution:
  geometry                           |    Merged in:
       Keywords:                     |    Reviewers:  Ben Hutz
        Authors:  Rebecca Miller     |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  eda3eef58a5b921d0e5a775551c6f20c490430ce
  u/rlmiller/ticket/19889            |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by jdemeyer):

 Some changes go from good to bad I think. In these cases, I prefer the
 original code:
 {{{
 #!diff
 -from sage.arith.all import lcm, gcd
 +from sage.arith.all                 import lcm, gcd
 }}}
 and
 {{{
 #!diff
 -            if not isinstance(polys, (list, tuple)):
 +            if not isinstance(polys,(list, tuple)):
 }}}
 and
 {{{
 #!diff
 -        Construct a point.
 +        Constructs a point.
 }}}

--
Ticket URL: <http://trac.sagemath.org/ticket/19889#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to