#19423: AsymptoticExpansion: combine shared code of invert, log, exp
-------------------------------------+-------------------------------------
       Reporter:  dkrenn             |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-7.1
      Component:  asymptotic         |   Resolution:
  expansions                         |    Merged in:
       Keywords:                     |    Reviewers:  Clemens Heuberger
        Authors:  Daniel Krenn       |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  68378745a4e792e5c58bdce9bb351debb7b239f9
  u/dkrenn/asy/exploginv_taylor      |     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by cheuberg):

 * status:  needs_review => needs_work
 * reviewer:   => Clemens Heuberger
 * milestone:  sage-6.10 => sage-7.1


Comment:

 1. What I had in mind was more commonality between the three methods: Most
 of the methods deal with writing `self = max_elem * (1 + geom)`. This part
 could be done by a common routine. (log and inversion a slightly more
 comfortable with `1 - geom`, but I'd prefer to read standard taylor
 coefficients.
 2. `_taylor_`:
   - I am not convinced of the name of the method. `_power_series_` ?
   - The role of `precision` is not explained.
   - There should be a doctest where a fixed point is reached before
 reaching `precision`
 3. logarithm: I think that it would be more readable to start with 0 and
 let the coefficients start at `k=1`.

--
Ticket URL: <http://trac.sagemath.org/ticket/19423#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to