#19969: asymptotic expansion generator: singularity analysis (log-type)
-------------------------------------+-------------------------------------
       Reporter:  behackl            |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.1
      Component:  asymptotic         |   Resolution:
  expansions                         |    Merged in:
       Keywords:                     |    Reviewers:  Clemens Heuberger
        Authors:  Benjamin Hackl     |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:  u/cheuberg/asy     |  7ad8f1626cd0647f8de9105442cbe730dc1232da
  /SA-generator-log                  |     Stopgaps:
   Dependencies:  #19532             |
-------------------------------------+-------------------------------------
Changes (by cheuberg):

 * status:  needs_work => needs_review
 * commit:  c83baa89cb1f86815d85fd4cf9aa579ecc117d2a =>
     7ad8f1626cd0647f8de9105442cbe730dc1232da


Comment:

 Replying to [comment:4 cheuberg]:
 > 1. I am not sure that three different implementations (beta=0, beta in
 ZZ and beta>0, otherwise) are needed: the only difference is the range
 over with `k`, `l`, `r` iterate and possibly the growth groups. But the
 basic coefficients stay the same. Perhaps we should even abolish the
 function `_sa_coefficients_e_` because collecting for a single
 `Gamma(alpha)` is not really worthwhile. That would mean removing the
 parameter `skip_constant_factor` which seems to be less important here.

 done.

 > 3. summation index `k` should be replaced by `r` in case beta not in ZZ
 in order to have consistent naming of summation indices.

 done.

 This amounts to a major rewrite of the code (old case beta=0 as well as
 new case). Please review.
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=f39f484721b7faa7a1fec1adc44d8ae424785c79
 f39f484]||{{{Trac #19993: Arb: parse symbolic expressions}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=c1dd748d1421aa7d457fe70371c4b1892f605917
 c1dd748]||{{{Merge branch 'arb/parse-symbolic' into t/19969/asy/SA-
 generator-log}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=9488698d3c73d9435144fa239c80ac31ddb9712a
 9488698]||{{{Trac 19969: remove parameter 'skip_constant_factor'}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=8938c974591fd6ef4cd609e646c0ca3ba4c69346
 8938c97]||{{{Trac #19969: unique code for all three cases}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=e769bde575d26ddcebe6cd1f42bb3ed7d9cc9f6e
 e769bde]||{{{Trac #19969: smaller coefficient rings if possible}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=feec36a5b6f4e5c2259bed7ec87f24a1212ccbc6
 feec36a]||{{{Trac #19969: prefer coefficients as multiples of
 1/Gamma(alpha)}}}||
 
||[http://git.sagemath.org/sage.git/commit/?id=7ad8f1626cd0647f8de9105442cbe730dc1232da
 7ad8f16]||{{{Trac #19969: remove obsolete comment}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/19969#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to