#20028: sorting of number field elements
-------------------------------------+-------------------------------------
Reporter: cremona | Owner:
Type: defect | Status: new
Priority: major | Milestone: sage-7.1
Component: number fields | Resolution:
Keywords: sort number field | Merged in:
elements | Reviewers:
Authors: | Work issues:
Report Upstream: N/A | Commit:
Branch: u/cremona/20028 | ecde78e4dd46a8be1125bd9d974f6f98698c989d
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by cremona):
* commit: 77618de1e986cc52605e071be2542e43d767bbc0 =>
ecde78e4dd46a8be1125bd9d974f6f98698c989d
* branch: u/nbruin/sorting_of_number_field_elements => u/cremona/20028
Comment:
I finished with the elliptic curves section, and uploaded the modified
branch as u/cremona/20028.
The principles I followed are:
1. Where there was sorting within the code, it is now always wrapped in
a try/except block which result in no sorting when a NotImplementedError
is raised. For cases where sorting is available there will be no change.
2. For the doctest outputs relating to isogenies, the outputs are now
sorted using key=str except when the base field is Q, or where the list
has at most one entry anyway. This required changing some doctest
outputs, mostly just the same but in a different order. I may have
overdone this in that over a finite prime field there was possibly sorting
already in place making the sort with key=str unnecessary, but this is
only doctest output anyway.
3. A couple of other places requred additions of the try/except
wrapping around sort operations. This includes a place in the isogeny
class code, on which I will do further work; interestingly the only
doctests which fail without that particular change is the one which caused
this in the first place (CM curves w.r.t an order of class number 6).
--
Ticket URL: <http://trac.sagemath.org/ticket/20028#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
