#20036: Add the grand antiprism to polytopes
-------------------------------------+-------------------------------------
Reporter: nvcleemp | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.1
Component: geometry | Resolution:
Keywords: | Merged in:
Authors: Nico Van Cleemput | Reviewers: Nathann Cohen
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/nvcleemp/add_the_grand_antiprism_to_polytopes|
d67941e9d3ae4ef6a803f2ce60ff4870bdddb604
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by ncohen):
* reviewer: => Nathann Cohen
Comment:
Helloooooooo !
Looks good.
Could you add a link toward the wikipedia page (using the `:wikipedia:`
role), which provides a longer description of this polytope?
Could you also add a reference toward the place where you obtained the
coordinates of the vertices?
In all other constructors of the file, it seems that 'exact=True' is the
default. Here, building the polytope on an exact ring takes around 11s on
my computer. Vincent, what do you think? Break the 'exact=True' standard
or make it slow by default, and fast upon request?
Finally, it's probably a question of style but you could first import
'product' from itertools, then only call 'product'. But well, that's
style, do whatever you prefer.
Thanks,
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/20036#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
