#20036: Add the grand antiprism to polytopes
-------------------------------------+-------------------------------------
Reporter: nvcleemp | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.1
Component: geometry | Resolution:
Keywords: | Merged in:
Authors: Nico Van Cleemput | Reviewers: Nathann Cohen
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/nvcleemp/add_the_grand_antiprism_to_polytopes|
8338831b8cb8ee29d9b04781435d6782f5045f2c
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by ncohen):
Helloooooo Nico,
My apologies for having been rather slow to answer during the last days. I
was on the moves with only my phone to read emails, and it was hard to do
anything Sage-related.
Thank you for the modifications you made to the code. I would say that a
doctest that takes 15 seconds to run is too long, especially if we can
"almost test it" by other means, i.e. with non-exact coordinates. So it is
fine for me to not test the `exact=True` branch.
About the default value: it is true that the 600-cells is already by
default in `exact=False` so, well, as this polytope is related to it I
guess that it is fine if you prefer to keep an `exact=False` there. There
is certainly some sense to it.
My last remark is about the reference you added: it looks odd, as a
'reference' entry usually contains additional details like title/author or
something. You can either improve the entry you added or, if you only want
to link toward some web page, merely add a link in the documentation.
Note that you can turn any text into a link with Sphinx, in case you do
not want the URL to appear in the doc:
http://doc.sagemath.org/html/en/developer/sage_manuals.html#hyperlinks
Good evening,
Nathann
--
Ticket URL: <http://trac.sagemath.org/ticket/20036#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
