#7021: [with patch; needs work] Update prereq from 0.3 to 0.4
-------------------------+--------------------------------------------------
 Reporter:  drkirkby     |       Owner:  tbd                      
     Type:  enhancement  |      Status:  new                      
 Priority:  blocker      |   Milestone:  sage-4.1.2               
Component:  build        |    Keywords:                           
 Reviewer:               |      Author:  David Kirkby, Minh Nguyen
   Merged:               |  
-------------------------+--------------------------------------------------

Comment(by GeorgSWeber):

 Reviewer report:

 1. There is a .bak-file in the tar-file in
 http://sage.math.washington.edu/home/kirkby/Solaris-fixes/prereq-0.4/ and
 a subdirectory "autom4te.cache", one might want to remove this file and
 this (entire) subdirectory.

 2. In "prereq-0.4-install", line 135, one might want to remove William's
 name and email-adress, just leave "email sage-devel" there (this has been
 another ticket already for all the Sage library code AFAIK).

 3. "prereq-0.4-install" is not executable, take care that it is.

 4. In configure.ac, line 22, please change AC_COPYRIGHT([GPL version 2])
 into AC_COPYRIGHT([GPL version 2, or (at your option) any later version]),
 and regenerate configure to reflect the update.

 5. (maybe a non-issue) In configure.ac, line 44, possibly missing
 parentheses after: AC_PROG_CPP

 I tried to do the test cases on my Mac, there's some gcc-3.3 and g++-3.3
 in /usr/bin/ additionally to the usual gcc(-4.0) and g++(-4.0). All in
 all, this looks good to me. IMHO the only blocker is 4. (the one about the
 license), the other findings are pretty unimportant.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7021#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to