#20078: Minimal non faces of simplicial complexes: Improve speed
-------------------------------------+-------------------------------------
Reporter: jipilab | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.1
Component: algebraic | Resolution:
topology | Merged in:
Keywords: simplicial | Reviewers: Travis Scrimshaw
complex, minimal nonface | Work issues:
Authors: Jean-Philippe | Commit:
Labbé | a231b06024e9fc1f327615631d6efb1a67b7d3a6
Report Upstream: N/A | Stopgaps:
Branch: |
u/jipilab/minnonface |
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by tscrim):
* reviewer: => Travis Scrimshaw
Comment:
Nice, at least a 5x speedup. My last comments:
- `any((set_candidate.issuperset(mnf) for mnf in set_mnf))` the inner
parenthesis `()` are redundant.
- `set_mnf` can be a `set` and `set_mnf =
set_mnf.union(frozenset([set_candidate]))` could become
`set_mnf.add(set_candidate)`.
- Change `cube.append([0, ])` -> `cube.append([0])` (and the same for `[1,
]`.
- Add the example in the ticket description as a doctest (maybe with a
comment indicating that this was slow before this ticket).
Once you make these changes, you can consider it a positive review by me.
--
Ticket URL: <http://trac.sagemath.org/ticket/20078#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
