#19653: New decoders for Generalized Reed-Solomon codes
-------------------------------------+-------------------------------------
       Reporter:  dlucas             |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.1
      Component:  coding theory      |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  David Lucas        |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/dlucas/grs_decoders              |  fca099ed40912d26eff991fc612ee793681000c5
   Dependencies:  #18928, #19897     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by jsrn):

 Two completely different things I just noticed:

 * I think the line `R(S.list_from_positions(xrange(0, l0+1)))` can, and
 should, be written `R(S[:l0+1])`.

 * In Berlekamp-Welch, and in Gao, you do a divisibility test followed by
 the actual division, i.e. you divide twice. You should instead use the
 `quo_rem` function to do the division once, and do the divisibility test
 by seeing if the remainder is zero.

--
Ticket URL: <http://trac.sagemath.org/ticket/19653#comment:39>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to