#19163: LatticePoset creation: Empty argument, better error reporting
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-7.1
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Jori Mäntysalo | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jmantysalo/latticeposet_creation__empty_argument__better_error_reporting|
0d0a09a405986b478644873761d2dd59cad03dc6
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by jmantysalo):
Replying to [comment:23 tscrim]:
> - I would consider making the no top/bottom errors just raise
`ValueError`. Granted, this won't look as slick when the error gets
reported, but it will be cleaner code. (This would mean we don't need
default values for `LatticeException`.) IMO this is also okay since
`LatticeException` inherits from `ValueError`.
But then I guess that `LatticePoset(P)` could say "not a ''semi''lattice",
assuming that I don't check the error string. Is that bad? Not that much,
but...?
--
Ticket URL: <http://trac.sagemath.org/ticket/19163#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
