#19163: LatticePoset creation: Empty argument, better error reporting
-------------------------------------+-------------------------------------
Reporter: jmantysalo | Owner:
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-7.1
Component: combinatorics | Resolution:
Keywords: | Merged in:
Authors: Jori Mäntysalo | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/jmantysalo/latticeposet_creation__empty_argument__better_error_reporting|
b42c0e7cabca4264e55291ff5e6114d1d00a0a7b
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by jmantysalo):
Replying to [comment:15 tscrim]:
> I would say the lack of response for your question (if it was "Am I
doing something stupid?") is a strong indication that you are not.
No. I do not trust silence being acception.
But see my commit on comment number 3. I guess it was something like what
you suggested.
> In more detail, the fragility comes from the fact that we have to
rewrite this error message if the underlying error message changes
wording.
That's why I added tests. We could also add a comment to the code raising
exception in `_meet()` and `_join()`.
> Also, the `int(error.message.split()[3][2:])` creates many, many new
transient objects: the `split`, in and of itself, creates a new list, plus
the `int`, plus each of the strings in the split.
Maybe I can optimize if, it one microsecond is too much...
--
Ticket URL: <http://trac.sagemath.org/ticket/19163#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
