#10819: implementation of the cluster complex
-------------------------------------+-------------------------------------
Reporter: stumpc5 | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.1
Component: combinatorics | Resolution:
Keywords: cluster complex | Merged in:
Authors: Christian Stump | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
public/ticket/10819 | 615b67fbcad7fc66484fd9d14fce4ae7564993a2
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by tscrim):
Hey Christian and Frédéric, here are my comments:
- We should use the standard copyright template from
http://doc.sagemath.org/html/en/developer/coding_basics.html#headings-of-
sage-library-code-files for all new files.
- The file should be added to the documentation.
- You should run the `TestSuite` on the cluster complex (often this is
done in the `__init__` tests).
- Error messages are typically not considered as sentences, so they should
start with a lower case and not end with a period.
- Your `__call__` does not appear to be idempotent, i.e., `C(C((0,1)))`
should equal (or even better, be identical to) `C((0,1))`.
- You aren't properly using the category framework by not having
`ClusterComplexFacet` as the `Element` attribute of `ClusterComplex`, and
subsequently, you should use `self.element_class` in `ClusterComplex`.
- The methods of `ClusterComplexFacet` should at least have a one-line
description of what the method does.
Some of these comments extend to the `SubwordComplex`, which might require
a separate ticket to work on.
--
Ticket URL: <http://trac.sagemath.org/ticket/10819#comment:28>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
