#19666: Guruswami-Sudan decoder for GRS codes
-------------------------------------+-------------------------------------
Reporter: dlucas | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.1
Component: coding theory | Resolution:
Keywords: | Merged in:
Authors: Johan Sebastian | Reviewers: dlucas
Rosenkilde Nielsen, David Lucas | Work issues:
Report Upstream: N/A | Commit:
Branch: | b4bc2572e40c26757fe80e4676d139519aef159e
u/dlucas/gs_list_decoding | Stopgaps:
Dependencies: #18928 |
-------------------------------------+-------------------------------------
Changes (by jsrn):
* commit: 2b0975090d03abeef343811a934646a33bcedc16 =>
b4bc2572e40c26757fe80e4676d139519aef159e
Comment:
> - There was an typo in `decode_to_message`'s doctest because of which
the test failed. I fixed it.
>
> - `_flatten_once` doctest had the flag `#random` while its output is not
random, thus I removed this flag.
OK.
> Here, I noticed you picked your examples so you get a list of `size >
1`, which I think is a good idea. I don't see a way to use this kind of
tests AND guarantee that list size will be at least two though...
Well, there is a way to autogenerate received words with a list size > 1,
but I think that would be total overkill. I vote for keeping the hard-
coded decoding example here to demonstrate the list size >1 while keeping
simplicity. But I understand why you changed the format of the other
tests, and it makes sense.
> Also, I don't really like the new title of `interpolation.py` module as
it appears in the index of modules:
>
> > Finding F[x]-roots, or modular F[x] roots, in polynomials over
F[x][y], where F is a (finite) field.
>
> With such a title, one does not immediately see how this module refers
to codes/decoding imho.
> It's a matter of taste I guess, so I'm not asking to change it, I'm just
pointing it.
Fair point. I guess I was exactly thinking about the modules' potential
outside coding theory. Can we strike a balance:
Finding F[x] roots for (F[x])[y] polynomials, with F a (finite) field,
as used in the Guruswami-Sudan decoding algorithm.
> On my side, I give the greenlight to all your changes. If you agree with
mine, I think we're good to go.
Cool. Let's agree on the above title and then ship it.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=8133531f6b880b4bd246cab4ad6ae430b4f4b494
8133531]||{{{Fixed typo in decode_to_message}}}||
||[http://git.sagemath.org/sage.git/commit/?id=b4bc2572e40c26757fe80e4676d139519aef159e
b4bc257]||{{{Removed #random flag from _flatten_once doctest}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/19666#comment:30>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
