#20103: Some clean up in simplicial complexes
-------------------------------------+-------------------------------------
Reporter: jhpalmieri | Owner:
Type: enhancement | Status: positive_review
Priority: minor | Milestone: sage-7.1
Component: algebraic | Resolution:
topology | Merged in:
Keywords: | Reviewers:
Authors: John Palmieri | Work issues:
Report Upstream: N/A | Commit:
Branch: u/jhpalmieri | caef059e1c09f1c400a754a8ead1e46798544a7d
/complex-cleanup | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by tscrim):
* status: needs_review => positive_review
Comment:
Replying to [comment:7 jhpalmieri]:
> Replying to [comment:6 tscrim]:
> > Replying to [comment:5 jhpalmieri]:
> > > Replying to [comment:4 tscrim]:
> > > > Some quick comments:
> > > > - I'm actually not sure if the output of a (python) `set` is
(attempted to be) sorted as for a `dict`. So I'm not sure if we need to
explicitly call `sorted`.
> > >
> > > Python sets are by definition unordered, so it seems safest to
explicitly call sort.
> >
> > Right, but the doctesting framework sorts the output of (some) things
automatically when running tests on a file to avoid having to do machine-
independent/memory-independent tests. I'm not opposed to doing the sort,
but just a note.
>
> It is completely opaque to me how this is done. Maybe by the code in
`repl/display/pretty_print.py` and `fancy_repr.py`? I only see references
to dictionaries being sorted by keys, not for other data types.
It's entirely possible we don't yet try to order `set` and only `dict`.
Okay, then we will explicitly sort things.
> > > > - Should we cythonize `algebraic_topological_model` now? It
probably won't be too hard and we could get some speedup from that.
> > >
> > > I am probably not the person to do that. It could safely go on
another ticket, since it seems independent of the changes here.
> >
> > I can cythonize it on a separate ticket then.
>
> CC me on it and I will review it.
This is now #20114.
So then this is now a positive review. Thanks!
--
Ticket URL: <http://trac.sagemath.org/ticket/20103#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
