#7126: [with patch, partial positive review, needs review] Doc sidebar broken by
Sphinx 0.6.3 JS compression
---------------------------+------------------------------------------------
Reporter: timdumol | Owner: tba
Type: defect | Status: new
Priority: minor | Milestone: sage-4.1.3
Component: documentation | Keywords:
Reviewer: Mitesh Patel | Author: Tim Dumol
Merged: |
---------------------------+------------------------------------------------
Changes (by mpatel):
* reviewer: => Mitesh Patel
Comment:
Thanks very much for finding these problems. I ran the JS code in
`layout.html` through [http://www.jslint.com/ JSLint] on the "The Good
Parts" setting and made the attached changes. Note: I didn't add
[http://ejohn.org/blog/ecmascript-5-strict-mode-json-and-more/ "use
strict";], since ECMAScript5 is not in widespread use. I also prepended a
"global" comment for `jQuery` and `window`, the latter for its
[http://www.quirksmode.org/dom/events/resize.html resize event].
I don't think Sphinx does any JS compression. I think a lone `$` in
Sphinx's `layout.html` causes `misc.html.math_parse()` and
`notebook.docHTMLProcessor.process_doc_html()` effectively to strip the
`\n`'s from the toggle code.
We should still fix the `$` problem, since Firebug and Opera's !DragonFly
complain about it. Worse yet, it makes Chromium's Developer Tools hang.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/7126#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en
-~----------~----~----~----~------~----~------~--~---
