#20133: Use pkg-config for Sage setup
-------------------------------------+-------------------------------------
       Reporter:  vbraun             |        Owner:
           Type:  enhancement        |       Status:  needs_work
       Priority:  major              |    Milestone:  sage-7.1
      Component:  build              |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Volker Braun       |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/fbissey/use_pkg_config_for_sage_setup|  
d4525c0860db5ea8657959ebcf33afb33c5b2b03
   Dependencies:  #20130             |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by jdemeyer):

 Replying to [comment:30 fbissey]:
 > Migrating building directives to `.pxd` files is an ongoing process.

 In the case of GSL, the library declarations are already migrated to
 `.pxd` files. So, if you want to fine-tune these declarations (by adding
 `library_dirs` for example), those fine-tuned declarations should also be
 in `.pxd` files. Otherwise it's a mess and we're worse off than before.

 Concretely, this should be reverted:
 {{{
 #!diff
 -    Extension('*', ['sage/gsl/*.pyx']),
 +    Extension('*', ['sage/gsl/*.pyx'],
 +              library_dirs = gsl_library_dirs,
 +              include_dirs = gsl_include_dirs),
 }}}

--
Ticket URL: <http://trac.sagemath.org/ticket/20133#comment:31>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to