#10819: implementation of the cluster complex
-------------------------------------+-------------------------------------
       Reporter:  stumpc5            |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.1
      Component:  combinatorics      |   Resolution:
       Keywords:  cluster complex    |    Merged in:
        Authors:  Christian Stump,   |    Reviewers:  Travis Scrimshaw
  Frédéric Chapoton                  |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  3c7d5ae34b0baf70f5486ebe15dbf77f477f0e2e
  public/ticket/10819                |     Stopgaps:
   Dependencies:  #20111, #20027     |
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'Christian Stump, Fr\xe9d\xe9ric Chapoton', 
'oldvalue': u'Christian Stump'}):

 * reviewer:   => Travis Scrimshaw
 * author:  Christian Stump => Christian Stump, Frédéric Chapoton


Comment:

 Indeed, greetings from Korea.

 I pushed some changes:

 - I moved the description of the cluster complex to the class-level doc
 (instead of the module-level doc) so it can be visible from
 `ClusterComplex?`.
 - I updated the reference bibliographic info.
 - I added more tests to `__classcall__` to make sure it covers all of the
 code paths/input formats.
 - I removed the verbose output from `TestSuite` as these can change as
 tests get added and it's annoying to make these trivial changes all over
 Sage (not that it happens that often).
 - Other misc tweaks.

 If you agree with my changes, then you can set a positive review.

--
Ticket URL: <http://trac.sagemath.org/ticket/10819#comment:54>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to