#20053: Singularity analysis for given singular expansions
-------------------------------------+-------------------------------------
Reporter: cheuberg | Owner:
Type: enhancement | Status: needs_review
Priority: minor | Milestone: sage-7.1
Component: asymptotic | Resolution:
expansions | Merged in:
Keywords: singularity | Reviewers:
analysis | Work issues:
Authors: Clemens Heuberger | Commit:
Report Upstream: N/A | 7acc4879e8992b286119e0ac6c0caf365032b9e5
Branch: u/cheuberg/asy | Stopgaps:
/allow-singular-expansion |
Dependencies: #20056, #19540 |
-------------------------------------+-------------------------------------
Comment (by behackl):
I've reviewed this implementation, and I only have one comment:
Could you revise the docstring of
`AsymptoticExpansion._singularity_analysis_`? Because
1. `var` can also be the generator of an asymptotic ring,
2. `zeta` is the location of the singularity, and
3. `precision` is **not** set to the default precision of the ring if it
is omitted, but has the same behavior as the `SingularityAnalysis` method
in the generators.
Do we want that the current behavior from 3 happens, so that the
asymptotic contribution has the same precision as the singular expansion
by default? Would be worth considering IMHO.
Other than that, `positive_review` form my side.
--
Ticket URL: <http://trac.sagemath.org/ticket/20053#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
