#20086: ZZ[X], QQ[X]: allow arbitrary powers of constant polynomials
-------------------------------------+-------------------------------------
Reporter: cheuberg | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-7.1
Component: basic arithmetic | Resolution:
Keywords: | Merged in:
Authors: Clemens Heuberger | Reviewers: Benjamin Hackl
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/cheuberg/polynomials/power | 14f7efaaf5be81405d1954473b4dc3f47100e486
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by cheuberg):
* commit: 87a22b6fc4cff82491a7b0ba35983bc5dc1299df =>
14f7efaaf5be81405d1954473b4dc3f47100e486
Comment:
Replying to [comment:11 behackl]:
> I've fixed the segmentation fault from `rings/integer.pyx` and
implemented the case of `constant^constant`.
That's weird, but as integer tries to convert the base to the base of the
exponent and expects the polynomial ring to handle it, we have to cope
with it.
>
> I've reviewed your changes, please cross-review. If you are satisfied
and if there are no other objections, I'd set this to `positive_review`.
I refactored the code: that way it seems to be more suitable for future
extension and handles polynomial exponents gracefully.
In a first commit, I removed handling of the segmentation fault because I
thought it should be handeled by the base ring; later on, I understood
that it has to be handeled here, so re-instated fix (in some other way).
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=e95c9b9ebbfb29a4e56585d89ee839b4fa910fca
e95c9b9]||{{{Trac #20086: refactor method; do not fix segmentation fault
2^R in polynomial ring}}}||
||[http://git.sagemath.org/sage.git/commit/?id=eadecbaec7b733554b996a1892d1a29421fe5153
eadecba]||{{{Trac #20086: fix ReSt errors (docbuild -u -k complains)}}}||
||[http://git.sagemath.org/sage.git/commit/?id=a1398689b7e2a2694100374c4bb2373d38fe5d7c
a139868]||{{{Trac #20086: handle non-constant polynomial exponents}}}||
||[http://git.sagemath.org/sage.git/commit/?id=14f7efaaf5be81405d1954473b4dc3f47100e486
14f7efa]||{{{Trac #20086: ReSt formatting}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/20086#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
