#20177: Better checks in GRS decoders
-------------------------------------+-------------------------------------
Reporter: dlucas | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.1
Component: coding theory | Resolution:
Keywords: | Merged in:
Authors: David Lucas | Reviewers: Johan Sebastian
Report Upstream: N/A | Rosenkilde Nielsen
Branch: | Work issues:
u/jsrn/checks_in_grs_decoders | Commit:
Dependencies: | 8f82e4eed97fe685862404856007c92a84746032
| Stopgaps:
-------------------------------------+-------------------------------------
Changes (by jsrn):
* commit: 9f5f20d505adc41b34c03135eaef05ed0eb2ce5c =>
8f82e4eed97fe685862404856007c92a84746032
* reviewer: => Johan Sebastian Rosenkilde Nielsen
Comment:
It looks good. I modified the tests that showed failure behaviour under
too many errors: "too many errors" is of course not well-defined (since
the receiver doesn't know the sent codeword); the relevant measure is the
distance to *any* codeword. Your test generated random errors of weight
`t+1`, where `t` is the decoding radius, and that would still decode into
some other codeword sometimes (albeit with extremely low probability). I
now changed it to a fixed example.
If you can accept this, please set it to positive review.
----
New commits:
||[http://git.sagemath.org/sage.git/commit/?id=8f82e4eed97fe685862404856007c92a84746032
8f82e4e]||{{{Clarification and non-randomization of some tests}}}||
--
Ticket URL: <http://trac.sagemath.org/ticket/20177#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
