#19873: update giac spkg
-------------------------------------+-------------------------------------
Reporter: frederichan | Owner:
Type: enhancement | Status: positive_review
Priority: minor | Milestone: sage-7.2
Component: packages: | Resolution:
optional | Merged in:
Keywords: | Reviewers: Vincent Delecroix
Authors: Frederic Han | Work issues:
Report Upstream: N/A | Commit:
Branch: | a959e0864a57795cb68523d108ac8495fa831d80
u/frederichan/giac122 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by vdelecroix):
* status: needs_work => positive_review
* reviewer: => Vincent Delecroix
Comment:
All right. I was able to run the doctests after decompressing the archive
{{{
$ sage -t --long --force-lib exemple.sage giacpy.pyx
Doctesting 2 files.
sage -t --long exemple.sage
[0 tests, 0.00 s]
sage -t --long giacpy.pyx
[221 tests, 23.89 s]
----------------------------------------------------------------------
All tests passed!
----------------------------------------------------------------------
Total time for all tests: 24.0 seconds
cpu time: 24.0 seconds
cumulative wall time: 23.9 seconds
}}}
This is good enough for this version...
Though
1. you should think about fitting Sage conventions for doctests:
- {{{a = b}}} instead of {{{a=b}}} for affectation
- no semicolon at the end of the statement
2. The way the two packages are organized do not follow the Sage
conventions, see [http://doc.sagemath.org/html/en/developer/packaging.html
Packaging from the developer manual]. In particular, it would be good to
have a test suite for giac. And to explicit the dependencies of the
packages.
--
Ticket URL: <http://trac.sagemath.org/ticket/19873#comment:36>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
