#19873: update giac spkg
-------------------------------------+-------------------------------------
Reporter: frederichan | Owner:
Type: enhancement | Status: positive_review
Priority: minor | Milestone: sage-7.2
Component: packages: | Resolution:
optional | Merged in:
Keywords: | Reviewers: Vincent Delecroix
Authors: Frederic Han | Work issues:
Report Upstream: N/A | Commit:
Branch: | a959e0864a57795cb68523d108ac8495fa831d80
u/frederichan/giac122 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by frederichan):
Replying to [comment:36 vdelecroix]:
> All right. I was able to run the doctests after decompressing the
archive
> {{{
> $ sage -t --long --force-lib exemple.sage giacpy.pyx
> Doctesting 2 files.
> sage -t --long exemple.sage
> [0 tests, 0.00 s]
> sage -t --long giacpy.pyx
> [221 tests, 23.89 s]
> ----------------------------------------------------------------------
> All tests passed!
> ----------------------------------------------------------------------
> Total time for all tests: 24.0 seconds
> cpu time: 24.0 seconds
> cumulative wall time: 23.9 seconds
> }}}
> This is good enough for this version...
Thank you
>
>
> Though
>
...
> 2. The way the two packages are organized do not follow the Sage
conventions, see [http://doc.sagemath.org/html/en/developer/packaging.html
Packaging from the developer manual]. In particular, it would be good to
have a test suite for giac. And to explicit the dependencies of the
packages.
I don't understand,
{{{
env SAGE_CHECK=yes make giac
}}}
has a long test suite, and build/pkgs/giac and giacpy have both a
dependencies file.
http://git.sagemath.org/sage.git/tree/build/pkgs/giac?id=98506d3754ddb14ca4548d644b2ed6b7a2d2a5d7
http://git.sagemath.org/sage.git/tree/build/pkgs/giacpy?id=98506d3754ddb14ca4548d644b2ed6b7a2d2a5d7
NB: running the giacpy testsuite is not enough for a review because some
sage doctests have the # optional - giac or giacpy flag.
{{{
src/sage/interfaces/giac.py
src/sage/matrix/matrix1.pyx
src/sage/modules/free_module_element.pyx
src/sage/symbolic/expression.pyx
src/sage/calculus/calculus.py
src/sage/libs/giac.py
src/sage/rings/polynomial/multi_polynomial_ideal.py
}}}
--
Ticket URL: <http://trac.sagemath.org/ticket/19873#comment:37>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
