#20136: Various meataxe build issues
-------------------------------------+-------------------------------------
       Reporter:  jdemeyer           |        Owner:
           Type:  defect             |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.1
      Component:  packages:          |   Resolution:
  optional                           |    Merged in:
       Keywords:                     |    Reviewers:
        Authors:                     |  Work issues:
Report Upstream:  Reported           |       Commit:
  upstream. Developers acknowledge   |  b6e16978528851ffb380449d72f3a529f543a4c9
  bug.                               |     Stopgaps:
         Branch:                     |
  u/SimonKing/various_meataxe_build_issues|
   Dependencies:                     |
-------------------------------------+-------------------------------------
Changes (by SimonKing):

 * status:  new => needs_review
 * commit:   => b6e16978528851ffb380449d72f3a529f543a4c9


Comment:

 It should be fine now. As far as I see,
 - I have addressed what we have discussed on the ticket,
 - !MeatAxe's test suite passes when installing it with the "-c" option,
 - the test suite does not leave garbage behind in SAGE_LOCAL/lib nor in
 the current directory (it does temporarily create garbage in
 SAGE_LOCAL/lib, but `spkg-install` removes it),
 - the tests in sage.matrix pass
 - the !MeatAxe wrapper in Sage sets a C variable `MtxLibDir` to
 `$DOT_SAGE/meataxe/`, and one of the patches makes !MeatAxe use it for its
 multiplication tables. Thus, again there is no garbage created.

 Needs review, I'd say!
 ----
 New commits:
 
||[http://git.sagemath.org/sage.git/commit/?id=b6e16978528851ffb380449d72f3a529f543a4c9
 b6e1697]||{{{Fix various MeatAxe build issues}}}||

--
Ticket URL: <http://trac.sagemath.org/ticket/20136#comment:49>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to