#20136: Upgrade meataxe and fix some build issues
-------------------------------------+-------------------------------------
Reporter: jdemeyer | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-7.2
Component: packages: | Resolution:
optional | Merged in:
Keywords: | Reviewers: Jeroen Demeyer
Authors: Simon King | Work issues:
Report Upstream: None of the above | Commit:
- read trac for reasoning. | b6e16978528851ffb380449d72f3a529f543a4c9
Branch: | Stopgaps:
u/SimonKing/various_meataxe_build_issues|
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by {'newvalue': u'Simon King', 'oldvalue': ''}):
* reviewer: => Jeroen Demeyer
* author: => Simon King
* milestone: sage-7.1 => sage-7.2
Comment:
Just looking at `spkg-src` for now...
1. I think it's better if it can be executed from `$SAGE_ROOT`, so I would
add `cd build/pkgs/meataxe` in the beginning.
2. You should move the tarball to `$SAGE_DISTFILES` (I know this isn't a
Sage shell, but you could do something like `./sage --sh -c 'mv ....
"$SAGE_DISTFILES"'`
3. Remove the `# commented out code`.
4. I don't see the point of `git commit -a -m "Add make target *dist*"`
since the tarball shouldn't contain the git repo.
--
Ticket URL: <http://trac.sagemath.org/ticket/20136#comment:51>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
