#19397: Add support for homogeneous components of a filtered module
-------------------------------------+-------------------------------------
       Reporter:  tscrim             |        Owner:  sage-combinat
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-6.10
      Component:  categories         |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Travis Scrimshaw   |    Reviewers:  John Palmieri
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  public/categories/homogeneous_components-19397|  
14f6a2843145309abe777e37ac2c96b8e5984d9a
   Dependencies:  #17096             |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by tscrim):

 This will definitely do as a workaround. We should add an additional check
 to make sure `self._indices` is finite and raise an error if not,
 otherwise the fallback for `homogeneous_component_basis` will run forever.

 Although if we are changing error messages, I think we should also change
 that `assert` to raise a `ValueError` on input because it is checking user
 input (and I like the convention that an `assert` is something that is
 expected to always be true).

 Minor point, but I don't think this import is needed anymore
 {{{
 from sage.categories.category_with_axiom import
 CategoryWithAxiom_over_base_ring
 }}}

 We will also need a follow-up ticket creating the proper (sub)category
 with an explanation that it causes an MRO failure.

--
Ticket URL: <http://trac.sagemath.org/ticket/19397#comment:35>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to