#20388: Fix the Magma interface to work with remote installations
-------------------------------------+-------------------------------------
Reporter: mmasdeu | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-7.2
Component: interfaces: | Resolution:
optional | Merged in:
Keywords: magma, remote | Reviewers:
Authors: Marc Masdeu | Work issues:
Report Upstream: N/A | Commit:
Branch: | c079a14424e9a1ea77179c658284b867b8401ef8
u/mmasdeu/20388-fix | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by vdelecroix):
Technically, you deprecated the import in the global namespace but not the
function in the module. In other words, this does not raise a warning as
it should
{{{
sage: sage.interfaces.magma.magma_version()
}}}
(because in the long run, we should just get rid of `magma_version`).
Would be better to simply deprecate `magma_version` and not modify
`all.py` using
{{{
def magma_version():
from sage.misc.superseded import deprecation
deprecation(20388, 'whatever')
return magma.version()
}}}
Other than that, everything looks good to me. Nils?
--
Ticket URL: <http://trac.sagemath.org/ticket/20388#comment:42>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
