#20402: Make subword complexes compatible with real reflection groups
-------------------------------------+-------------------------------------
Reporter: stumpc5 | Owner:
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-7.2
Component: combinatorics | Resolution:
Keywords: reflection group, | Merged in:
coxeter group, subword complex, | Reviewers:
days80 | Work issues:
Authors: Christian Stump | Commit:
Report Upstream: N/A | 52c39d9ef149ee6826cb3f8f06b7aa7582d49f14
Branch: u/stumpc5/20402 | Stopgaps:
Dependencies: #11187 |
-------------------------------------+-------------------------------------
Changes (by tscrim):
* status: needs_review => needs_work
Comment:
It's looking a lot better Christian. Thank you.
However, let me be a bit more stern, I will not set this ticket to a
positive review when you essentially remove doctest coverage because
`gap3` is not an optional package yet (although this argument weakens once
it is). Moreover, you can test all of the functionality with standard
Sage, which such tests should be localized to each method, not (only) in a
class-level test which does the "core" functionality.
For the speed issues, how much of this is making a difference? If it does,
you can separate out the important functionality into a separate method,
and then subclass the general class which special cases the methods when
you use `ReflectionGroup`.
You are right about the issue with `Lambda`.
By renaming `action_on_root_indices`, you need to deprecate it.
I am okay with you adding an `is_crystallographic` to the group here, but
it might be a little strange if the crystallographic-ness of a Coxeter
group is different than its Coxeter type/matrix.
Also, instead of `act`, IIRC there is a method, which I believe is
`_act_on_` (not to be confused with `_acted_upon_`), that automatically
gets checked by the coercion framework. So it gives you `w * la`
essentially for free. Although
--
Ticket URL: <http://trac.sagemath.org/ticket/20402#comment:25>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
