#20509: khovanov homology of links
-------------------------------------+-------------------------------------
Reporter: mmarco | Owner:
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-7.2
Component: algebraic | Resolution:
topology | Merged in:
Keywords: knots | Reviewers:
Authors: Miguel Marco | Work issues:
Report Upstream: N/A | Commit:
Branch: | ea937a9e5f263eecdfe9ca32272cbb07a00d582f
u/mmarco/khovanov_homology_of_links| Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by tscrim):
Some comments:
- I don't see the point of having attributes `_smoothing` and
`_enhanced_states`, these should be separated out into `@cached_method`.
Although it seems like `_enhanced_states` is all you really need.
- Instead of `type(_) == tuple`, use `isinstance(_, tuple)`.
- Instead of
{{{#!python
difs = [_ for _ in range(len(V1[0])) if V1[0][_] != V2[0][_] ]
}}}
you can do
{{{#!python
V20 = V2[0]
difs = [index for index,value in enumerate(V1[0]) if value != V20[index] ]
}}}
- The output of `khovanov_homology` is mutable, so it should not be
cached.
--
Ticket URL: <http://trac.sagemath.org/ticket/20509#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
