#20086: rational powers in ZZ[X] and QQ[X]
-------------------------------------+-------------------------------------
Reporter: cheuberg | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-7.1
Component: basic arithmetic | Resolution:
Keywords: | Merged in:
Authors: Clemens | Reviewers: Benjamin Hackl
Heuberger, Vincent Delecroix | Work issues:
Report Upstream: N/A | Commit:
Branch: | 6bf385b18875572eeb4ab748eb8f25124bce6acf
u/behackl/polynomial/rational- | Stopgaps:
powers |
Dependencies: |
-------------------------------------+-------------------------------------
Changes (by behackl):
* status: needs_info => needs_review
Comment:
Replying to [comment:44 vdelecroix]:
> It is fine for me if you modify the generic `nth_root` to
> {{{
> u = f.unit()
> if u.is_one():
> # do nothing
> elif self.parent() != self.base_ring():
> # try to factorize the unit in the base ring
> else:
> # raise a NotImplementedError
> }}}
>
> EDIT: small modif in the code `self != self.base_ring()` ->
`self.parent() != self.base_ring()`
Thanks for the suggestion! I've pushed some changes such that the unit is
handled with more care. Apart from that, I've reviewed the documentation
changes and doctests already in the past, this is still fine for me.
Please cross-review. :-)
--
Ticket URL: <http://trac.sagemath.org/ticket/20086#comment:46>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
