#20487: Numpy build broken on Cygwin since #20450
-------------------------------------+-------------------------------------
Reporter: embray | Owner:
Type: defect | Status: needs_info
Priority: major | Milestone: sage-7.2
Component: porting: Cygwin | Resolution:
Keywords: cygwin windows | Merged in:
numpy | Reviewers: Sebastien Gouezel
Authors: Erik Bray | Work issues:
Report Upstream: N/A | Commit:
Branch: | 76b3369f7386d0082f7e7d19d78550a307fde610
u/embray/ticket-20487 | Stopgaps:
Dependencies: |
-------------------------------------+-------------------------------------
Comment (by jdemeyer):
Replying to [comment:11 embray]:
> Why would I change package-version.txt?
To elaborate a bit on this: the build system of Sage tracks versions of
installed packages. If you change the `spkg-install` script or change
patches of a package, Sage will ''not'' automatically rebuild that
package.
If you do want the package to be rebuilt, you need to increase the
patchlevel in `package-version.txt`. This means either appending `.p0` or
changing `.pN` to `.p(N+1)`.
You should always increase the patchlevel when changing the `spkg-install`
script or patches of a package ''unless there is a good reason not to''.
Typical reasons "not to":
- A completely trivial change, like a typo.
- A change which affects only the '''build system''' of the package but
does '''not change the installed package''' (not even in a minor way).
- The change affects only a particular platform '''and''' the package did
not '''build''' on that platform before.
Regardless of the above reasons, a reviewer should always check that the
changed package builds and works fine. This means doing a forced rebuild
of the package using `sage -f PACKAGE`. Ideally, a build from scratch
(`make distclean; make`) should also be tested.
--
Ticket URL: <http://trac.sagemath.org/ticket/20487#comment:13>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
