#20086: rational powers in ZZ[X] and QQ[X]
-------------------------------------+-------------------------------------
Reporter: cheuberg | Owner:
Type: defect | Status: needs_review
Priority: major | Milestone: sage-7.2
Component: basic arithmetic | Resolution:
Keywords: | Merged in:
Authors: Clemens | Reviewers: Benjamin Hackl,
Heuberger, Vincent Delecroix, | Vincent Delecroix
Benjamin Hackl | Work issues:
Report Upstream: N/A | Commit:
Branch: public/20086 | e56adf4325379d05441efb4dd9487c2cc7904ddc
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Comment (by vdelecroix):
Replying to [comment:77 behackl]:
> Replying to [comment:75 nbruin]:
> > Perhaps don't bother getting a grammatically correct ordinal. Note
that the current code doesn't get it correct anyway: It's 21st, 22nd,
23rd.
> >
> > Better to formulate the error message in a way that doesn't depend on
correct ordinal spelling, e.g.
> > `ValueError("(%s)^(1/%s) does not lie in ring"%(f,n))`
> >
>
> I do like the version with explicit ordinals in the errors more, so I
fixed them. :-)
Having the following code executed each time the function run is useless
{{{
if 10 <= n % 100 < 20:
postfix = 'th'
else:
postfix = {1:'st', 2:'nd', 3:'rd'}.get(n % 10, 'th')
}}}
Moreover, having these four lines potentially anywhere in Sage because you
like is not the way to go. If you really think it is better this way, then
implement a function `ordinal_str` that would ''really'' be doctested.
In the error message proposed by Nils there was the explicit mention of
the parent which is a good thing.
--
Ticket URL: <http://trac.sagemath.org/ticket/20086#comment:78>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
