#20561: Return cycle type of a permutation
-------------------------------------+-------------------------------------
       Reporter:  andrew.mathas      |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.2
      Component:  group theory       |   Resolution:
       Keywords:  permutation,       |    Merged in:
  cycle type                         |    Reviewers:
        Authors:  Andrew Mathas      |  Work issues:
Report Upstream:  N/A                |       Commit:
         Branch:                     |  b9acb7729e678ee46ef6db66a694c3040db830d0
  u/andrew.mathas/return_cycle_type_of_a_permutation|     Stopgaps:
   Dependencies:                     |
-------------------------------------+-------------------------------------

Comment (by vdelecroix):

 You should fix the `OUTPUT` section.

 In the doctest and the code, there would better be a space on each side of
 the equality sign {{{a = b}}} instead of {{{a=b}}}. This is just code
 convention. But it helps reading if this is uniform.

 It costs nothing to add an option `singletons` to your `cycle_type`
 method. It is sometimes useful to ignore the fixed points.

--
Ticket URL: <http://trac.sagemath.org/ticket/20561#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to