#20555: descents for Permutations : cleanup
-------------------------+-------------------------------------------------
Reporter: | Owner:
chapoton | Status: needs_review
Type: | Milestone: sage-7.2
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers:
combinatorics | Work issues:
Keywords: | Commit:
permutation | 0e1c23bc2d7326980c1970e7fc0fcb379a629f78
Authors: | Stopgaps:
Frédéric Chapoton |
Report Upstream: N/A |
Branch: |
u/chapoton/20555 |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by stumpc5):
> I do not understand you first point.
Maybe I misunderstand the {{{tester}}}, but isn't this test supposed to
pass always? What if I use {{{index_set = ['A','B','C']}}}, would it still
pass then with this test?
{{{
tester.assert_(i not in si.descents(positive=True, side='left'))
tester.assert_(i not in si.descents(positive=True, side='right'))
}}}
If you want, you could be also explicit in those tests.
Beside those two points, I give it a positive review given the patchbot
turns green.
--
Ticket URL: <http://trac.sagemath.org/ticket/20555#comment:20>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
