#20598: py3 print in schemes folder
-------------------------+-------------------------------------------------
Reporter: | Owner:
chapoton | Status: needs_review
Type: | Milestone: sage-7.3
enhancement | Resolution:
Priority: major | Merged in:
Component: | Reviewers: Jori Mäntysalo
python3 | Work issues:
Keywords: | Commit:
Authors: | 322c52f65ea71b005b2a2d6ed0334be81c38ce58
Frédéric Chapoton | Stopgaps:
Report Upstream: N/A |
Branch: |
public/20598 |
Dependencies: |
-------------------------+-------------------------------------------------
Comment (by jmantysalo):
There is an unneeded spaces after `=` at
{{{
print("Q = ", Q, ": Order(Q) = ", Q.order())
}}}
To other direction for example
{{{
if debug: print("n1a=", n1a)
}}}
has "missing" space. They were there before you, so I don't count them for
reviewing, just a note.
I think that
{{{
print([z.quadratic_form() for z in y.conjugates_over_K()])
}}}
has unnecessary `print`. This is just a matter of taste.
Everything seems to be good. However, I am on slow machine now, so
''positive_review'' will be delayed until I got this compiled and tested.
--
Ticket URL: <http://trac.sagemath.org/ticket/20598#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
