#20370: generic GCD-free basis
-------------------------------------+-------------------------------------
Reporter: mmezzarobba | Owner:
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-7.2
Component: algebra | Resolution:
Keywords: | Merged in:
Authors: Marc Mezzarobba | Reviewers:
Report Upstream: N/A | Work issues:
Branch: | Commit:
u/mmezzarobba/20370-gcd_free_basis | 49660c68deb9f70de6772a383c1dd8845c9e74ce
Dependencies: | Stopgaps:
-------------------------------------+-------------------------------------
Changes (by mmezzarobba):
* reviewer: Bruno Grenet =>
Comment:
Thanks for the review!
Replying to [comment:7 bruno]:
> I would prefer another ticket: As it is, if you remove the commits about
`Sequence()`, I am ready to set it to positive review. I am much less
confident on the code involving `Sequence` and need more time (or another
reviewer...)!
Done (#20621).
> A comment still on the `Sequence()` part: Should'nt the error message
explicitly mention that there is a conflict with the universe? Something
like
> {{{unable to convert {} to an element of the universe ({})".format(x[i],
universe))}}}
I don't think so: when `Sequence()` is used internally by another function
(e.g. in the present case), it will be clear that the function needs to
somehow convert some elements to a given parent, but it doesn't matter
that this parent is the universe of some Sequence (and that may even make
the error more confusing to casual users)...
--
Ticket URL: <http://trac.sagemath.org/ticket/20370#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.
