#20370: generic GCD-free basis
-------------------------------------+-------------------------------------
       Reporter:  mmezzarobba        |        Owner:
           Type:  enhancement        |       Status:  needs_review
       Priority:  major              |    Milestone:  sage-7.2
      Component:  algebra            |   Resolution:
       Keywords:                     |    Merged in:
        Authors:  Marc Mezzarobba    |    Reviewers:
Report Upstream:  N/A                |  Work issues:
         Branch:                     |       Commit:
  u/mmezzarobba/20370-gcd_free_basis |  e0895632b8cc12e990f859dbdbb0d086601a6afe
   Dependencies:                     |     Stopgaps:
-------------------------------------+-------------------------------------

Comment (by bruno):

 Replying to [comment:6 mmezzarobba]:
 > > You may catch the exception and raise your own `TypeError: the
 elements you provided do not belong to QQ` (or something similar).
 Actually I ran into the exact example I paste above...
 >
 > I improved `Sequence()` itself instead. Of course, I can move the
 corresponding commits to another ticket if you don't feel like reviewing
 them.

 I would prefer another ticket: As it is, if you remove the commits about
 `Sequence()`, I am ready to set it to positive review. I am much less
 confident on the code involving `Sequence` and need more time (or another
 reviewer...)!

 A comment still on the `Sequence()` part: Should'nt the error message
 explicitly mention that there is a conflict with the universe? Something
 like
 {{{unable to convert {} to an element of the universe ({})".format(x[i],
 universe))}}}

--
Ticket URL: <http://trac.sagemath.org/ticket/20370#comment:7>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/sage-trac.
For more options, visit https://groups.google.com/d/optout.

Reply via email to